Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: avoid passing userId in User queries
......................................................................
engine: avoid passing userId in User queries
Motivation: in the included queries (user queries), a user id
is passed in parameters.
In user query there is no point in passing userId (it can be taken
from session in server side).
Removed user id paramerters classes, query base class, related tests, and
references both in UI and REST.
Note: although there can be a use case for fetching other user vm/pools, it
can be revisited upon request (currently there is no use for that).
Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java
D
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDataByUserIDQueriesBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java
D
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQueryTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQueryTest.java
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmPoolsAttachedToUserParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserVmsByUserIdAndGroupsParameters.java
D
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetAllVmPoolsAttachedToUserParametersTest.java
D
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetUserVmsByUserIdAndGroupsParametersTest.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
12 files changed, 16 insertions(+), 216 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/12458
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>