Allon Mureinik has submitted this change and it was merged. Change subject: frontend: Tests for ConstantsWithLookup classes ...................................................................... frontend: Tests for ConstantsWithLookup classes oVirt engine's classes that inherit from ConstantsWithLookup (AppErrors and VdsmErrors) are used to translate enum constants (EngineMessage and EngineError, accordingly). This patch completes the work done in previous patches and adds tests to make sure these classes don't contain translations for keys that have been removed from the enumss. This patch contains: * A new base class AbstractConstantsWithLookupTestCase with the testing functionality. * New tests based on this functionality - AppErrorsTest and VdsmErrorsTest. * Cleaning up AppErrors from redundant constants to make the test pass. Change-Id: Ibb65dfe76e3284fac24f4d63e311c068107fc276 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AbstractConstantsWithLookupTestCase.java A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AppErrorsTest.java A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/VdsmErrorsTest.java 4 files changed, 63 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb65dfe76e3284fac24f4d63e311c068107fc276 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org