
From Arik Hadas <ahadas@redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79986 ) Change subject: core: do not use placeholder for nic's network ...................................................................... core: do not use placeholder for nic's network This place-holder just complicates things. We can just generate the NIC's part in the domain XML that fits for legacy bridges and let VDSM replace the inner 'source' element in case it is a non legacy bridge. The innder 'source' element that VDSM is provided with contains the network name and that is the only information it apparently needs. Change-Id: I377c52fde263dcf8f8318d180884185574365d6a Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I377c52fde263dcf8f8318d180884185574365d6a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Francesco Romani <fromani@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>