Tal Nisan has submitted this change and it was merged. Change subject: core: old SetupNetworks fix. ...................................................................... core: old SetupNetworks fix. when creating new bond with VLAN using old setupnetworks command, base nic is calculated and cannot be found in db, because it wasn't created yet. NPE was produced, when trying to find NetworkAttachment using ID of inexisting nic. Check was added so code does not try to find such NetworkAttachment in such scenario. Consequence is, that it there's QOS defined on NetworkAttachment, it won't be applied. However this is not regression since this command is deprecated and never supported overridding QOS. Bug-Url: https://bugzilla.redhat.com/1271524 Change-Id: I9a2db946352bbd02eaa2dd64b98badd71050b6d3 Signed-off-by: Martin Mucha <mmucha@redhat.com> (cherry picked from commit 1e081274a7034ce137f9346dcafc9240cbaa784b) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a2db946352bbd02eaa2dd64b98badd71050b6d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org