Maor Lipchuk has submitted this change and it was merged. Change subject: core: Cleanup DiskDao and its tests ...................................................................... core: Cleanup DiskDao and its tests General cleanup in the DAO and its tests: 1. Made private methods static where possible 2. migrated Guid string constants from the test to FixturesTool so they could be reused. 3. Renamed some test methods to be more readable Change-Id: I9551288f38b537c8196f2a2d79012457a0220cc1 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java 3 files changed, 22 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9551288f38b537c8196f2a2d79012457a0220cc1 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>