Change in ovirt-engine[master]: core: RestoreAllSnapshots partial cleanup
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RestoreAllSnapshots partial cleanup
......................................................................
core: RestoreAllSnapshots partial cleanup
- Replace the class member 'targetSnapshot' with local field.
- Change the type of deleteDisksIds from List to Set, which is more
appropriate (as it should contain every value at most once), and
it improves the performance of the loop in #deleteOrphanedImages.
- Change the type of 'snapshotsToRemove' member from List to Set,
instead of ensuring that it doesn't contain any value more than once
when inserting to it.
Change-Id: I0557a832915e00877f9d1ee79e4cf2d429537396
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
1 file changed, 16 insertions(+), 19 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0557a832915e00877f9d1ee79e4cf2d429537396
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>