Change in ovirt-engine[master]: core: RemoveQuotaCommandTest remove unused mocks
Tal Nisan has submitted this change and it was merged.
Change subject: core: RemoveQuotaCommandTest remove unused mocks
......................................................................
core: RemoveQuotaCommandTest remove unused mocks
Removed redundant mocks that set up DAOs that were never used by the
command. After these removals, testSetup() just called mockQuotaDao,
so it was removed completely and instead the mockQuotaDao method was
made public and annotated with a @Before annotation directly.
Change-Id: I8e901eaede62cbfe5a0f7a57e0bf23f964a2e772
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java
1 file changed, 1 insertion(+), 35 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64774
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e901eaede62cbfe5a0f7a57e0bf23f964a2e772
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>