Tal Nisan has submitted this change and it was merged. Change subject: core: Disallow domains of mixed subtype (file/block) in <3.4 storage pool ...................................................................... core: Disallow domains of mixed subtype (file/block) in <3.4 storage pool Disallow adding domains of a different subtype (file/block) that the domains alread contained in the pool with a compatibility version lower than 3.4 which contains domain Change-Id: I8226c29e6c34ab6434d0a5ec07aa7fa1d4d00306 Bug-Url: https://bugzilla.redhat.com/1083560 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 37 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8226c29e6c34ab6434d0a5ec07aa7fa1d4d00306 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server