Change in ovirt-engine[master]: core: Fixing NPE in case of endCommand failure
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing NPE in case of endCommand failure
......................................................................
core: Fixing NPE in case of endCommand failure
This is a suggestion on how to fix an NPE in
CreateAllSnapshotFromVmCommand that is caused by network error at
CreateSnapshotCommand (the child command).
The network error causes transaction rollback and removal of the
new snapshot entity (and making the old one non active).
I had to create this patch in order to verify previous patches in
this patchset.
Bug-Url: https://bugzilla.redhat.com/982003
Change-Id: I78a617f43bd297db13b7dc9ad6649b67c773c144
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 14 insertions(+), 10 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78a617f43bd297db13b7dc9ad6649b67c773c144
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server