Change in ovirt-engine[engine_3.2]: packaging: fix default filemod in copyFile
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: fix default filemod in copyFile
......................................................................
packaging: fix default filemod in copyFile
copyFile used to call os.chmod(file, filemod) with filemod defaulting
to '-1'. Older linux kernels kept the mode unchanged in such a case, but
newer ones don't. More details in the "Bug-Url" link below.
This change defaults filemod to None and only calls os.chown if filemod
is set.
Bug-Url: https://bugzilla.redhat.com/1011616
Change-Id: I9e436d72e8ffb8d48e05201727d5b46797881556
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Ofer Schreiber: Verified; Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/19557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e436d72e8ffb8d48e05201727d5b46797881556
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org