Change in ovirt-engine[master]: core: limit disk alias and description for disk metadata
Tal Nisan has submitted this change and it was merged.
Change subject: core: limit disk alias and description for disk metadata
......................................................................
core: limit disk alias and description for disk metadata
On block storage, the disk metadata is limited to 512 bytes.
Since we store its alias and description in the metadata, we should
limit their size or else they will be truncated by vdsm and we won't be
able to read them.
This patch limits the value of the metadata description field size to a
maximum of 210 bytes. We do it also for file storage in order to prevent
a truncation of the description field when moving a disk from file to
block storage.
Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac
Bug-Url: https://bugzilla.redhat.com/1258547
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 218 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Maor Lipchuk: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45551
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org