From Juan Hernandez <juan.hernandez@redhat.com>:
Juan Hernandez has submitted this change and it was merged. Change subject: Use DiskAttachment.active explicitly ...................................................................... Use DiskAttachment.active explicitly The 'DiskAttachment.active' attribute isn't mandatory when adding a disk attachment to a virtual machine, but if it isn't provided the result is undefined: the disk will be active in some situations, and won't in some other situations. To avoid that uncertainty it is better to always include it with the desired value. This patch changes the examples accordingly. Change-Id: Idc5675b5174aab5ec1707dd677c8bf8f1fe77483 Related-To: https://bugzilla.redhat.com/1390517 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M sdk/examples/add_vm_disk.rb 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc5675b5174aab5ec1707dd677c8bf8f1fe77483 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>