Allon Mureinik has submitted this change and it was merged. Change subject: core: ListUtils#listsEqual(Collection, Collection) ...................................................................... core: ListUtils#listsEqual(Collection, Collection) org.ovirt.engine.core.common.utils.ListUtils#listEqual(java.util.Collection, java.util.Collection) is basically copy-pasted from java.util.AbstractCollection.containsAll(java.util.Collcetion). This patch replaces the copy-pasted code with a call to containsAll. It not only cleans up the code, but also offers the opportunity for specific collections that override this method to provide a better implementation. Change-Id: Ifbf2686a69143086ea4ed766b3f70329e26ad34e Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf2686a69143086ea4ed766b3f70329e26ad34e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>