Change in ovirt-engine[master]: core: Roles commands cleanup
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Roles commands cleanup
......................................................................
core: Roles commands cleanup
1. Replaced ArrayList declarations with List declarations where
possible.
2. Replaced DbFacade.getInstance().getXXDAO() with getXXDAO().
3. Added serialVersionId.
4. Removed unsused classes: RoleActionCommandBase and
RolesActionMapParameters.
5. Addressed Eclipse IDE warnings.
6. Changed protected methods from CSharpNamingConvention to
javaNamingConvention.
Change-Id: I3eb8e7f5ba3504f3fbd45c8c5685c03539bcb67c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveRoleCommand.java
D
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RoleActionCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesOperationCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRoleCommand.java
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RolesActionMapParameters.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
11 files changed, 57 insertions(+), 102 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eb8e7f5ba3504f3fbd45c8c5685c03539bcb67c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>