Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Refactor CommonNetworkValidation ...................................................................... engine: Refactor CommonNetworkValidation 1. Moved to super class (since only used from inheriting classes of NetworkCommon). 2. Changed to instance method, which allows: 2.1. Using DAO instance methods. 2.2. Using addCanDoActionMessage method. 3. Renamed method & variables to appropriate names. Change-Id: Ie55a702efbeaaa852de93411fc5eaebc68ceefff Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 19 insertions(+), 24 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie55a702efbeaaa852de93411fc5eaebc68ceefff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Muli Salem <msalem@redhat.com>