Change in ovirt-engine[master]: webadmin: Fix "updateNumaPinning"
Juan Hernandez has submitted this change and it was merged.
Change subject: webadmin: Fix "updateNumaPinning"
......................................................................
webadmin: Fix "updateNumaPinning"
According to findbugs this method creates a useless object:
Useless object created
Our analysis shows that this object is useless. It's created and
modified, but its value never go outside of the method or produce any
side-effect. Either there is a mistake and object was intended to be
used or it can be removed.
This analysis rarely produces false-positives. Common false-positive
cases include:
- This object used to implicitly throw some obscure exception.
- This object used as a stub to generalize the code.
- This object used to hold strong references to weak/soft-referenced
objects.
Bug kind and pattern: UC - UC_USELESS_OBJECT
In this particular case it looks like a real issue. This patch fixes the
method so that the created object isn't useless.
Change-Id: Ib7ae9e8ee956895b30848ba2ae7e2a713fc6f17e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NumaUnitToVmBaseBuilder.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Alexander Wels: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46555
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7ae9e8ee956895b30848ba2ae7e2a713fc6f17e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org