Change in ovirt-engine[master]: core: remove memory image on remove snapshot
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove memory image on remove snapshot
......................................................................
core: remove memory image on remove snapshot
If snapshot contains memory and it is the only one that contains that
memory, remove the memory volumes when removing the snapshot as well.
Note that there might be cases where more than one snapshot contain the
same memory:
1. when preview snapshot, the memory volume is copied from the snapshot
that is being previewed to the active snapshot
2. when running vm in stateless mode, the memory volume is copied to
the active snapshot
3. in the future we might support cloning a VM with its memory
state (clone from snapshot + import as clone) and the memory would be
copied to the cloned VM's snapshots
Change-Id: Ib0b4f5306c23046326c9dbb7ef5589b50c88462d
Bug-Url: https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/dbscripts/snapshots_sp.sql
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java
5 files changed, 150 insertions(+), 25 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0b4f5306c23046326c9dbb7ef5589b50c88462d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server