Arik Hadas has submitted this change and it was merged. Change subject: core: Graphics devices sorted for VM creation ...................................................................... core: Graphics devices sorted for VM creation We currently support two concurrent graphics protocols: SPICE+VNC. However qemu can have only one sound driver and thus only one protocol can get the sound. Libvirt sets audio driver (QEMU_AUDIO_DRV variable) according to the last graphics device in domain xml. Until now the order of graphics device have depended on database result ordering (i.e. has been random). This patch puts SPICE at the end so if SPICE+VNC is selected, SPICE always gets the sound. Change-Id: I93a8c597355e27235e528d1a9cb28d893a1f219f Bug-Url: https://bugzilla.redhat.com/1371243 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/ComparatorUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 2 files changed, 62 insertions(+), 4 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a8c597355e27235e528d1a9cb28d893a1f219f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>