Change in ovirt-engine[master]: core: fix for locks not being released in sync commands
Roy Golan has submitted this change and it was merged.
Change subject: core: fix for locks not being released in sync commands
......................................................................
core: fix for locks not being released in sync commands
This patch fix the following problem: when acquiring locks inside
a command which has a synchronous flow and set not to release its
locks after the 'execute' method, the locks remain forever in the
synchronous flow since the end-action is not called.
Note: synchronous flow means there are no tasks being created in the
execute method. for example: when exporting a template that has no
disks.
The solution is to release the locks at the end of the 'execute' method
if the command has no tasks.
Change-Id: I8f39b924327fb0a8e1081ca9bde6b24f489a7c1e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f39b924327fb0a8e1081ca9bde6b24f489a7c1e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server