Change in ovirt-engine[master]: core: added missing logging + refactoring
Moti Asayag has submitted this change and it was merged.
Change subject: core: added missing logging + refactoring
......................................................................
core: added missing logging + refactoring
org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector#saveToDb
was missing logging in situation, when 'bundles/AuditLogMessages'
resource bundle does not contain specific translation. In that case
AuditLog was silently not created and nothing was logged.
- added missing logging
- overgrown method saveToDb split into few smaller ones.
- removed coding smell when dealing with variables 'message' and
'resolvedMessage'
- simplified test for empty string.
Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 82 insertions(+), 89 deletions(-)
Approvals:
Martin Mucha: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/29244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server