Change in ovirt-engine-sdk[master]: sdk: No new lines in basic auth token
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: No new lines in basic auth token
......................................................................
sdk: No new lines in basic auth token
Currently we generate the value of the basic authentication header using
the "encodestring" method of the "base64" module, but the output of
this
method may contain many new lines, depending on the length of the user
name and password. When more than one newline is included we only delete
the last, and as a result we generate a header with a new line, which is
interpreted by the web server as two headers, thus breaking the
authentication mechanism. This patch changes the SDK so that all the new
lines are removed.
Change-Id: I02bb66b5bed9c152fcba95ab577373b66f19be05
Bug-Url: https://bugzilla.redhat.com/1085837
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/ovirtsdk/web/connection.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26752
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02bb66b5bed9c152fcba95ab577373b66f19be05
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org