Change in ovirt-engine[master]: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
......................................................................
webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
EnterIgnoringFocusHandler -> onPreviewNativeEvent:
execute 'enterPressed' on ONKEYDOWN event instead of
ONKEYPRESS to overcome an issue in newer Chrome/FF
browsers, in which the textarea doesn't catch the
ONKEYPRESS event. Consequently, pressing enter key
in a textarea won't break to a new line
(e.g. 'Custom Script' textarea).
Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server