3:31 a.m.
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: fix import/general sub-tab
......................................................................
webadmin: fix import/general sub-tab
The general sub-tab in the import dialog was broken by recent changes in
the frontend - it didn't present the VM information.
This patch fixes the sub-tab that shows general information on VM in the
import dialog. I changed the sub-tab to be separate component that
doesn't inherit the VM general sub-tab in the virtual machines tab
because they differ in:
1. Layout - in the sub-tab which is presented in the import dialog, we
don't need to have the alerts tab since warnings/errors will be shown
differently
2. Items - the presented fields are different and over-time they are
expected to be changed in a way that they will be even more different
3. Configurability - in the import sub-tab some fields are editable.
currently only the name and the operating system but there should be
more, while in the general sub-tab nothing is editable
Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.ui.xml
7 files changed, 776 insertions(+), 31 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/39586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server