Tal Nisan has submitted this change and it was merged. Change subject: core: allowed to add network label even if Vm using this network is running. ...................................................................... core: allowed to add network label even if Vm using this network is running. ~ Network label was checked to be unchanged in method 'onlyPermittedFieldsChanged'. This is extracted out into new method 'allowedNetworkLabelManipulation' which returns true if network label was not changed, or if former label was not specified (null) and new one is specified (!=null). ~ moved methods out from non static SyncNetworkParametersBuilder. These methods can be used outside from SyncNetworkParametersBuilder, but in that case their owning class have to be instantiated using CommandContext parameter, which is completely unrelated to these four methods. Bug-Url: https://bugzilla.redhat.com/1134009 Change-Id: Ic4e37a36bc8ae1b5614c3c6d218fb13a4e59a021 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 22 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e37a36bc8ae1b5614c3c6d218fb13a4e59a021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server