Change in ovirt-engine[ovirt-engine-3.6]: webadmin: v2v VMware handle special chars in uri
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: v2v VMware handle special chars in uri
......................................................................
webadmin: v2v VMware handle special chars in uri
VMware seems to allow all special chars for data center, folder and cluster
name.
We should handle it correctlly in v2v engine side by encoding those
chars before sening them to VDSM.
This solution encodes the VMware data center and VMware cluster parts of
the uri
i.e. for uri vpx://user@vcenter/DATACENTER/CLUSTER/esxi?no_verify=1
we encode the DATACENTER and CLUSTER parts, including folders if
exists. Other parts of the uri are left decoded.
In UI we continue to display the data center and cluster as was
originally typed by the user (decoded).
The encoding is done on frontend and therefore should be also done while
using REST apis for v2v.
known problems:
If you include the following chars in VMware datacenter or
cluster, the import failed:
%, \, / ->
error of "Could not find datacenter specified in uri..." appesrs
&, +, =, ? ->
error of "virt-v2v: internal error: invalid argument: cannot fetch XML"
a bug is opened on libvirt/virt-v2v for that.
Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb
Bug-Url: https://bugzilla.redhat.com/1379363
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineException.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
3 files changed, 12 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/64461
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>