5:39 a.m.
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Allow to supply additional info on SetupNetworks violations
......................................................................
engine: Allow to supply additional info on SetupNetworks violations
Add ability to supply addtional info on SetupNetworks violations
Add networks parameter for NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS
message.
Change-Id: I51b18ec02f16c1315b446cfaaccc8701693eafca
Bug-Url: https://bugzilla.redhat.com/1115098
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/MultiValueMapUtils.java
A
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/DetailedViolation.java
A
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/ViolatingEntityDetails.java
A
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/Violation.java
A
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/ViolationRenderer.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
14 files changed, 225 insertions(+), 53 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/43841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51b18ec02f16c1315b446cfaaccc8701693eafca
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org