Change in ovirt-engine[master]: restapi: Avoid NPE in QoS mapper
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Avoid NPE in QoS mapper
......................................................................
restapi: Avoid NPE in QoS mapper
The mapper is used also when processing an update, and in that case the
"type" can be empty, thus triggering an exception when calling
"toLowerCase". This patch moves the conversion to lower case to the
place where it is actually needed, and where we know that the value
won't be null.
Change-Id: I31ee09a1eb1cd9a706a88fe836b04dfa404841a5
Bug-Url: https://bugzilla.redhat.com/1274187
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java
M
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosTypeMapper.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47630
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31ee09a1eb1cd9a706a88fe836b04dfa404841a5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org