Change in ovirt-engine[master]: core: minor cleanups
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor cleanups
......................................................................
core: minor cleanups
* Remove _destinationVds from RunVmCommandBase and put relevant fields
in RunVmCommand & MigrateVmCommand. It is better in terms of
encapsulation since they are now private
* Refactor RunVmCommand#getDestinationVds to be more readable
* Remove MigrateVmCommand#forcedMigrationForNonMigratableVM
* Remove explicit usages of DbFacade class within MigrateVmCommand
* Few renames
Change-Id: I2fa22569d9195f69cec7fa9c0a4931b2975e41ec
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
6 files changed, 60 insertions(+), 51 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fa22569d9195f69cec7fa9c0a4931b2975e41ec
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server