Change in ovirt-engine[master]: tools: don't rely on Connection.isValid()
Allon Mureinik has submitted this change and it was merged.
Change subject: tools: don't rely on Connection.isValid()
......................................................................
tools: don't rely on Connection.isValid()
Patch 9f856a6234566a2ab648ef580fa102192ec43b10 refactored
StandaloneDataSource.checkConnection() to use Connection.isValid() in
order to avoid a FindBugs warning on an unused function result.
Apparently, this approach is problematic since the PostgreSQL JDBC
driver we're using does not implement isValid().
This patch reverts 9f856a6234566a2ab648ef580fa102192ec43b10 and proposes
a different way to avoid the FindBugs warning.
Change-Id: Ic4f1fe6a9981c6fe8764a803eda4de5d51cc2b6e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java
1 file changed, 20 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4f1fe6a9981c6fe8764a803eda4de5d51cc2b6e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>