Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: remove uneeded sed's ...................................................................... spec: remove uneeded sed's We have 3 sed command in spec file that are deprecated: 1. > # semanage is not present in the image and virt_use_nfs is on (see rhbz#642209)
# remove it from vdsmd startup script to avoid error sed -i 's#/usr/sbin/semanage#/bin/true#' /etc/rc.d/init.d/vdsmd
We don't have semanage command anymore in /etc/rc.d/init.d/vdsmd and ovirt-node these days provide semanage command. 2. > # libvirtd upstart job is already configured on rhevh
sed -i 's/ && start_libvirtd$//' /etc/rc.d/init.d/vdsmd
There is no start_libvirtd anymore in /etc/rc.d/init.d/vdsmd 3. > # chkconfig results (symlinks) cannnot be peristed
sed -i 's#/sbin/chkconfig \$srv off##' /etc/rc.d/init.d/vdsmd
No more /sbin/chkconfig $srv off in /etc/rc.d/init.d/vdsmd Change-Id: I98ecf410204f081b5cea730a87b2aca8786e3a87 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1088218 Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98ecf410204f081b5cea730a87b2aca8786e3a87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand@fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs@redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server