Change in ovirt-engine[master]: core: simplified RunVmValidator#canRunVm method
Roy Golan has submitted this change and it was merged.
Change subject: core: simplified RunVmValidator#canRunVm method
......................................................................
core: simplified RunVmValidator#canRunVm method
The RunVmValidator#canRunVm should be a utility method that invoke the
validations which are required for running a VM, but it was also used to
have logic which determines whether to invoke images related validations
or not.
This patch changes the canRunVm method to invoke all the validations
(until the first failure) without any filtering. Instead, The images
related validations are checking whether the VM has images or not
inside.
Change-Id: I277a24fa26bb9aae3641aa316689ff7350e9d63f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
1 file changed, 37 insertions(+), 29 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I277a24fa26bb9aae3641aa316689ff7350e9d63f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server