Change in ovirt-engine[master]: core: do not restrict user public keys to RSA
Moti Asayag has submitted this change and it was merged.
Change subject: core: do not restrict user public keys to RSA
......................................................................
core: do not restrict user public keys to RSA
The users can upload ssh public keys, to be used to perform
authentication in to the ovirt-vmconsole-proxy, and then to
connect to virtio serial console.
For early implementation reasons, the key type was restricted to
RSA. This patch lift the restrictions, allowing the user to
upload any valid SSH key.
The code should now perform only the basic sanity check.
Change-Id: If3b677a140cdedd478856bf8aa62ac758932767e
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
M
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
3 files changed, 70 insertions(+), 32 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3b677a140cdedd478856bf8aa62ac758932767e
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org