Change in ovirt-engine[master]: core: Enable ConfigureConsoleOptionsQuery for paused VMs
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Enable ConfigureConsoleOptionsQuery for paused VMs
......................................................................
core: Enable ConfigureConsoleOptionsQuery for paused VMs
ConfigureConsoleOptionsQuery had too strict VM status requirements that
allowed to open console only for VMs in Running state. Added
VMStatus.isQualifiedForConsoleConnect() method that returns true for any
VM status that is qualified for opening console connection. This method
is used in both frontend and backend.
Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234932
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
4 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org