Martin Sivák has submitted this change and it was merged. Change subject: upgrade: fix upgrade from partially upgraded condition ...................................................................... upgrade: fix upgrade from partially upgraded condition The upgrade procedure has to move the hosted-engine configuration to the shared storage and it has to disconnect the hosted-engine storage domain from its bootstrap storage pool. The two tasks can be performed by different attempts. _move_to_shared_conf was connecting the bootstrap storage pool leaving it connected for further steps. _remove_storage_pool was assuming that it was already connected. But if the configuration volume is OK it skips _move_to_shared_conf and, if the system has been rebooted in the middle, _remove_storage_pool fails cause the storage pool is not connected. Connecting the storage pool if needed also from _remove_storage_pool Change-Id: Ibc5782d2f245129b2bb2f7e70f2558d820eb4267 Bug-Url: https://bugzilla.redhat.com/1292652 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 21 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/50700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc5782d2f245129b2bb2f7e70f2558d820eb4267 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>