Change in mom[master]: Improve the message when getVmMemoryStats() returns 0
Martin Sivák has submitted this change and it was merged.
Change subject: Improve the message when getVmMemoryStats() returns 0
......................................................................
Improve the message when getVmMemoryStats() returns 0
Mom is currently expecting a non-zero return for memory usage to assume
ovirt-guest-agent is active, and throws an warning log along with an 'error'
message if the first check has a 0ed return.
This patch removes the 'error' string in the warning message and also
includes the VM uuid in the message to improve the message relevance.
Change-Id: I4afba631f190440810b3f022987ff152773ac6e6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234953
Signed-off-by: Amador Pahim <apahim(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45596
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
---
M mom/Collectors/GuestMemory.py
M mom/HypervisorInterfaces/vdsmInterface.py
M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Amador Pahim: Verified
--
To view, visit https://gerrit.ovirt.org/45596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4afba631f190440810b3f022987ff152773ac6e6
Gerrit-PatchSet: 4
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>