Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Removed recursion for readability's sake
......................................................................
webadmin: Removed recursion for readability's sake
The attach and detach commands were being run in parallel, so that
when both terminate the dialog is closed and the source tab is
refreshed. However, this was implemented in a bizarre recursion which
wasn't trivial to follow. Hopefully it is more readable now.
Change-Id: I4cb3238dbc82cbf8f41d9bf93889649f8d021f54
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java
1 file changed, 34 insertions(+), 29 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/22905
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cb3238dbc82cbf8f41d9bf93889649f8d021f54
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server