Change in ovirt-engine[ovirt-engine-3.5]: core: wrong nesting: not detecting label & VmNetwork changes
Tal Nisan has submitted this change and it was merged.
Change subject: core: wrong nesting: not detecting label & VmNetwork changes
......................................................................
core: wrong nesting: not detecting label & VmNetwork changes
this equality checks are badly nested causing the last two lines does
not do what intended. Instead:
oldNetwork.isVmNetwork()
is compared to
newNetwork.isVmNetwork()) && Objects.equals(oldNetwork.getLabel(),
newNetwork.getLabel());
which wasn't probably wanted.
Change-Id: I50c748071e09fb062ce08aedd1af71db6c4e280d
Bug-Url: https://bugzilla.redhat.com/1139590
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50c748071e09fb062ce08aedd1af71db6c4e280d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server