Change in ovirt-engine[master]: core: dedicated query for monitored network interfaces
Arik Hadas has submitted this change and it was merged.
Change subject: core: dedicated query for monitored network interfaces
......................................................................
core: dedicated query for monitored network interfaces
Previously, we used GetVmNetworkInterfaceViewByVmId that uses the
costly vm_interface_view in order to query the network interfaces
whose statistics are being monitored.
This patches adds a new procedure that uses a much lighter view
than vm_interface_view that will be used by the monitoring instead.
There is still a lot of place for improvement but this change
seems to be the simpler and one that would probably be needed
along with further improvements anyway as it reduces the time to
fetch the data by more than four times.
Change-Id: I475ffe644c7636e1e3a5ddea474d08f4b6ee80bd
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoImpl.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
5 files changed, 84 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Alona Kaplan: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I475ffe644c7636e1e3a5ddea474d08f4b6ee80bd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>