Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: clean up db connection plugins
......................................................................
packaging: setup: clean up db connection plugins
Move around code to proper locations - engine connection from
connection.py to engine_connection.py, and setup-related from common to
setup, similarly to engine and reports.
Without this patch, engine-cleanup with dwh fails if problems in
postgresql.conf are found.
Bug-Url:
https://bugzilla.redhat.com/1176457
Bug-Url:
https://bugzilla.redhat.com/1077267
Change-Id: I64fff2d8fc9677e6138581add9c167501d9c783e
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py
4 files changed, 198 insertions(+), 136 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit
https://gerrit.ovirt.org/37870
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64fff2d8fc9677e6138581add9c167501d9c783e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server