Change in ovirt-engine[master]: core: Fix equals/hashCode in VmOperationParameterBase and ch...
Martin Peřina has submitted this change and it was merged.
Change subject: core: Fix equals/hashCode in VmOperationParameterBase and children
......................................................................
core: Fix equals/hashCode in VmOperationParameterBase and children
VmOperationParameterBase overrides hashCode() but not equals() which
break equals/hashCode contract. If we would add equals() to
VmOperationParameterBase, then we would have to add it also to all
children, but only 2 children of total 40 currently implements
equals/hashCode as other children don't need them. So this patch:
1. Removes hashCode() method from VmOperationParameterBase
2. Fixes equals/hashCode in MigrateVmParameters and RunVmParam to use
also vmId attribute from VmOperationParameterBase.
Change-Id: Ied9481e198397b364fc7781425c733b44128f08f
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmOperationParameterBase.java
3 files changed, 33 insertions(+), 38 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied9481e198397b364fc7781425c733b44128f08f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>