Change in ovirt-engine[ovirt-engine-3.5]: aaa: Change the check of internal command execution
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Change the check of internal command execution
......................................................................
aaa: Change the check of internal command execution
Both canDoAction and executeAction set the isSucceeded flag
to false if they fail.
We should check if AddUser or AddGroup failed not just by their
canDoAction phase, but also by their execution phase.
Hence, using the isSuceeded flag is more appropriate solution.
Bug-Url: https://bugzilla.redhat.com/1121954
Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server