Change in ovirt-engine[master]: core: Fixes StackOverflowError during fencing
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fixes StackOverflowError during fencing
......................................................................
core: Fixes StackOverflowError during fencing
Fixes StackOverflowError appeared during execution of fencing operation.
This fix removes commandContex instance and overriden getContext() from
RestartVdsCommand, because command context in CommandBase should be set
always during creation of command and successful locks aquiring is
checked prior to executeCommand call in CommandBase.
Also when RestartVdsCommand and its inherited commands are using global
command context, VdsKdumpDetection command executed from
VdsNotRespondingTreatmentCommand should also use global command context
and not its copy.
The overriden getContext() has been introduced in
Iaf021010188e3c3662fbf8a057da4c58f2600c02.
Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c
Bug-Url: https://bugzilla.redhat.com/1124141
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
3 files changed, 2 insertions(+), 16 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server