Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: enable units testing ...................................................................... packaging: enable units testing - added %check in the spec file, calling make check - added check-local target in src/ovf where a unit test already existed - cleaned up ovfenvelopetest.py - avoid syntax check on generated file ovfenvelope.py Change-Id: Ic4a3988c7067ece7f6ea60834182a2585a2f7545 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com> --- M .gitignore M ovirt-image-uploader.spec.in M src/ovf/Makefile.am M src/ovf/ovfenvelopetest.py 4 files changed, 35 insertions(+), 27 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4a3988c7067ece7f6ea60834182a2585a2f7545 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com>