6:55 a.m.
Itamar Heim has submitted this change and it was merged.
Change subject: core: Don't duplicate directory name in the DB
......................................................................
core: Don't duplicate directory name in the DB
Currently in the "users" table we store the directory name in the
"domain" column and also, as a suffix added to the user name, in the in
the "username" column. This duplication causes confusion, and makes the
SQL schema a bit more non normalized. This patch removes that
duplication and changes the places that need to display the directory
name (GUI and RESTAPI) so that it is done explicitly.
Bug-Url: https://bugzilla.redhat.com/1055881
Bug-Url: https://bugzilla.redhat.com/1059258
Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 2d36ccaecbf6a83340525083980f98ddff064e48)
---
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java
M
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
A
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FormatUtils.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/create_functions.sql
A packaging/dbscripts/upgrade/03_04_0640_remove_directory_suffix_from_login_name.sql
11 files changed, 98 insertions(+), 38 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Juan Hernandez: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server