Change in ovirt-engine[master]: core: add default value for custom properties
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add default value for custom properties
......................................................................
core: add default value for custom properties
For some flows the custom properties of VM were not initialized, thus
they could be null. When the VM was edited from the UI, if no custom
properties were set, they were set to empty string. This inconsistency
caused false alarms on checks whether the custom properties were changed
- because a transition from null to empty string was detected as change.
This patch defines empty string as a default value for the custom
properties. It is safe since in all its usages, we check whether the
custom properties is null or empty string.
Change-Id: I74cc88b9bef6ace4a608c6d15f27b9c8f678564d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/27882
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74cc88b9bef6ace4a608c6d15f27b9c8f678564d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server