Change in ovirt-engine[master]: engine: Validate AuditLogMessages.properties
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Validate AuditLogMessages.properties
......................................................................
engine: Validate AuditLogMessages.properties
This patch adds AuditLogMessagesTest, an AbstractPropertiesTestBase
to validate the contents of AuditLogMessages.properties against the
AuditLogType enum, and cleans up all the violations:
1. Where keys have duplicate translations, the one with less information
is removed.
2. Keys missing from AuditLogType were removed
3. Keys corresponding to those in (2) in LocalizedEnums.java and
LocalizedEnums.properties were also removed.
Change-Id: I5c016997d9f4229ddd11488a700898d1ecad8d57
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
A
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogMessagesTest.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 10 insertions(+), 25 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c016997d9f4229ddd11488a700898d1ecad8d57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>