Allon Mureinik has submitted this change and it was merged.
Change subject: core: set action msg for ForceRemoveStorageDomain
......................................................................
core: set action msg for ForceRemoveStorageDomain
Set action message type (var action) in setActionMessageParameters
instead of setting it in canDoAction.
When setting it in canDoAction, it's initialized only after
the locks are checked, hence error message due to a lock
displays $action and not the real value because it's initialized too late.
Change-Id: Ib5f2e1b4e525693be8cd8ce06b17be14e2f8a57c
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/15097
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f2e1b4e525693be8cd8ce06b17be14e2f8a57c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>