Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Cleanup of AdElementListModel constructor
......................................................................
webadmin: Cleanup of AdElementListModel constructor
Cleanup part of the bugfix patch
Nested async call moved to be parallel as it was not dependent
of its parent
Async calls logic encapsulated from mid method anonymous class
to its own method
Improved variable names for readability
Change-Id: Iacc5878f32f5b5395dd5a87a0614b4c3a21bf88d
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
1 file changed, 48 insertions(+), 49 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/12667
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacc5878f32f5b5395dd5a87a0614b4c3a21bf88d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: noam slomianko <drekmastermind(a)gmail.com>