Tal Nisan has submitted this change and it was merged. Change subject: core: simplify RemoveUserProfileCommand ...................................................................... core: simplify RemoveUserProfileCommand RemoveUserProfileCommand had too complex check logic which never triggered. The problem is that client code always use UserID as key, and it may not know (and care about) the profile ID. This patch simplifies the code without making the command less correct: like the other UserProfileCommands, any logged user can only change its own profile. Change-Id: Ie08dd783be8e60207ef49bf98fd991b357391fd7 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java 4 files changed, 17 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie08dd783be8e60207ef49bf98fd991b357391fd7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani@redhat.com> Gerrit-Reviewer: Francesco Romani <fromani@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org