Change in ovirt-engine[master]: core: make PollVMStatsRefresher abstract
Arik Hadas has submitted this change and it was merged.
Change subject: core: make PollVMStatsRefresher abstract
......................................................................
core: make PollVMStatsRefresher abstract
Better class hierarchy for poll-based vm-stats refreshers is to have an
abstract class that contains the common things for polling and then
specific refreshers will extend it.
This patch changes PollVMStatsRefresher to be abstract and presents a
new refresher PollListAndAllVmStatsRefresher that extends it and
implements the legacy polling that we used to have before 3.6.
In addition, PollAllVmStatsOnlyRefresher is changed to implement only
the things that varies instead of override the 'poll' method.
Change-Id: I2d6277d3ca0ab14a9431284a13744943b6a4945b
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollAllVmStatsOnlyRefresher.java
A
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollListAndAllVmStatsRefresher.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java
4 files changed, 62 insertions(+), 36 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42789
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d6277d3ca0ab14a9431284a13744943b6a4945b
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org